bcgov / bcgov/foi-flow

Changing Request to 'Records Review' w/ Fee Estimate - No 'Add File' Option in State Change Modal

Open
#3,718 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

**Describe the bug in current situation**

Currently, when a request has a fee estimate and a fee estimate is paid partially or in full (online through MOD, or manually entered), when a user changes the request from Call for Records or Harms Assessment to Records Review, the 'Add File' option is not displayed in the modal.

However, when there is no fee estimate, when changing the request from Call For Records or Harms Assessment to Records Review, the 'Add File' option is displayed in the modal.

See EDU-2022-00083 (Call For Records) or EDU-2023-58696 (Harms Assessment) in Test for examples of requests with fee estimate, and when changing the request to Records Review, the 'Add File' option does not appear in the state change modal.

In addition to the noted above, when changing a request from Call For Records -> Records Review, with a fee estimate paid in full or partial, the wrong modal wording appears. See images below for more information.

**Impact of this bug**
Low

**Chance of Occurring (high/medium/low/very low)**
High

**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**
Test

**Steps to Reproduce**

1. Go to a General request in Test environment, that is in 'Call for Records'
2. Enter fee estimates, and approve the fee estimates through CFR Form tab
3. Either place the request On Hold and pay the fees through the FOI online payment page, or move the request back to Call for Records and enter a paid amount manually.
4. When the request is in Call for Records, enter the Actuals in the CFR Form tab.
5. Move the request from Call for Records -> Records Review (or, change the request from Call for Records -> Harms Assessment -> Records Review).
6. When the state change modal opens when changing the request to Records Review, the 'Add File' option is not available.

**Expected behaviour**

GIVEN any request is having the state changed from Call for Records or Harms Assessment to Records Review
WHEN the state change modal opens
THEN the 'Add Files' option is available in the modal, and the correct wording is displayed

**Screenshots/ Visual Reference/ Source**

This is the modal when going from Call For Records -> Records Review, where a fee estimate has been paid in full or partial. It's not showing the 'Add File' option, nor is the wording correct. The correct modal is added as another image.

![image](https://user-images.githubusercontent.com/117312323/234926372-7e793d97-fc7e-41d4-a6a5-43098d32a811.png)

This is the modal when going from Harms Assessment -> Records Review, where a fee estimate has been paid in full or partial. It's not showing the 'Add File' option, but the wording is correct.

![image](https://github.com/bcgov/foi-flow/assets/117312323/3c733ce5-176f-41a9-bb54-488bc151ac1d)

Correct modal, showing 'Add File' option, and correct wording - currently only displayed when there is no fee estimate.

![image](https://user-images.githubusercontent.com/117312323/234921764-19a7cc3e-5529-4d89-8fa8-49347c9ffa50.png)

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Reproduce the state change in the Test environment with a General request that has a partially or fully paid fee estimate, then compare the modal for Call for Records or Harms Assessment to Records Review with the no-fee-estimate case. Done means the Add Files option and correct wording appear in both transitions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.