bcgov / bcgov/foi-flow

Non-Pilot Ministry - Fee Estimate Form Statuses and Editing

Open
#2,575 4 comments 0 reactions 0 assignees View on GitHub
Story
Dominant language
Python
Stars
8
Forks
2
Avg merge
14h 34m
Merged PRs (30d)
46

Description

* As a user working on a non-pilot Ministry request
* I want to update the status of the fee estimate form
* so that I know what action needs to be taken

**Assumptions & Scope**
Similar to our pilot Ministries - non-pilot Ministry requests will also have a status associated with them. This will ultimately be used to trigger when a fee can be submitted.

The three status will be "In Review with IAO" (default), "Needs Clarification with Ministry" and "Approved"

For non-pilot Ministries, saving and updating the status will be more of an internal trigger/notification. Will need to disable "Needs clarification with Ministry" as Ministry users will not be set up. In addition - we will be unlocking the form to allow IAO to change any of the fields in the fee estimate form.

What is IN scope?
Changing status of the fee form

What is NOT in scope?
Other actions associated with the status

**Acceptance Criteria**

**Scenario 1: Needs Clarification Disabled**
* GIVEN a user is on the fee estimate form of a non-pilot Ministry request
* WHEN they activate the drop down for CFR form status
* THEN the options they will have will be: "Approved" and "Needs Clarification with Ministry"
* AND the option for Needs clarification with Ministry will be greyed out and unselectable

**Scenario 2: Activate Save Button**
* GIVEN a user has activated the drop down of the CFR status
* WHEN they select an active status other than the one they have selected
* THEN the save button will become active.

**Scenario 3: Activate Save Button**
* GIVEN a user has selected a new status for the CFR Form
* WHEN they click on the save button
* THEN the CFR form status will update
* AND a toast will appear briefly, indicating the save was successful

**Scenario 4: CFR Form Editable when In Review**
* GIVEN a user is on the fee estimate form of a non-pilot Ministry request
* WHEN the status of the fee estimate form is "In review with IAO"
* THEN all of the fields in the form will be editable
* AND edits will be consistent with the existing fee form logic

**Scenario 5: CFR Form Not Editable when In Approved**
* GIVEN a user is on the fee estimate form of a non-pilot Ministry request
* WHEN the status of the fee estimate form is "Approved"
* THEN all of the fields in the form will be locked
* AND the user can not make edits

**Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)**

**Validation Rules? (If yes, list here)**

**Design**
https://jacklyn808742.invisionapp.com/console/share/3W2O64AP5C/941000371

**Definition of Ready**

1. [ ] Is there a well articulated User Story?
2. [ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
3. [ ] If there is a user interface, is there a design?
4. [ ] Does the user story need user research/validation?
5. [ ] Does this User Story needs stakeholder approval?
6. [ ] Design / Solution accepted by Product Owner
7. [ ] Is this user story small enough to be completed in a Sprint? Should it be split?
8. [ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
9. [ ] Has the story been estimated?

**Definition of Done**

1. [ ] Passes developer unit tests
2. [ ] Passes peer code review
3. [ ] If there's a user interface, passes UX assurance
4. [ ] Passes QA of Acceptance Criteria with verification in Dev and Test
5. [ ] Confirm Test cases built and succeeding
6. [ ] No regression test failures
7. [ ] Test coverage acceptable by Product Owner
8. [ ] Ticket ready to be merged to master or story branch
9. [ ] Developer to list Config changes/ Update documents and designs
10. [ ] Can be demoed in Sprint Review
11. [ ] Tagged as part of a Release
12. [ ] Feature flagged if required
13. [ ] Change Management activities done?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.