bcgov / bcgov/entity

Remove obsolete fields from API business response

Open
#8,827 1 comment 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE Priority3 techdebt
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

The `business.arMaxDate` and `business.arMinDate` fields are not used by the UI, so they can be deleted from the business endpoint response. (The UI instead uses the data from the AR filing meta.)

Note that the API may still want to calculate these values to validate the Annual Report dates when an AR is filed.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the business endpoint response and the code that validates Annual Report dates when an AR is filed. Trace how business.arMaxDate and business.arMinDate are assembled, then check the relevant API tests if present. Done means the response omits both fields while Annual Report date validation still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, python
Domain
api, backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.