bcgov / bcgov/entity

Oracle CANCEL_RESUBMIT logging improvement

Open
#523 0 comments 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE NameX
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

### Oracle CANCEL_RESUBMIT logging improvement
## Description:

If a certain error happens when nro-update calls the NRO_DATAPUMP_PKG, an error message is written to the NAMESDB.APPLICATION_LOG table (this is good). The result is that:

1. We know an error happened (if somebody checks the log).
1. The results of one examination failed to update the Oracle database.
1. A client is not going to receive the results of their name examination, nor be able to consume the name (if approved).
1. We _do not_ know which name request had the failure (this is bad).

The error message, at the time of writing NRO_DATAPUMP_PKG.CANCEL_RESUBMIT:292 should include information to identify the name request. It looks like the NR number is not readily accessible in the procedure, but for the low volume of errors the `p_request_id` is better than nothing.

See bug #527 for how to reproduce the error message production.

Ready to Build (DoR):
- [ ] Stakeholders have approved
- [ ] User story completed
- [ ] What are the dependencies
- [ ] Acceptance criteria has been defined (happy path, known sad paths)
- [ ] Validation rules defined (UI, Data, Role-Action)
- [ ] Is a formal UAT required

Acceptance / DoD:
- [ ] Design / Solution accepted by Product Owner
- [ ] Test coverage acceptable
- [ ] Peer Reviewed
- [ ] UX Approved
- [ ] PR Accepted
- [ ] Production burn in completed

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.