bcgov / bcgov/entity

IA Correction - Usability enhancements to People and Roles table

Open
#5,192 4 comments 0 reactions 0 assignees View on GitHub
bug ENTITY - DO NOT USE Priority2 UX Assurance
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Scott identified a number of usability issues with the 'undo' button

Visual/UX Design Ticket:
https://app.zenhub.com/workspaces/entity-5bf2f2164b5806bc2bf60531/issues/bcgov/entity/5124

1) ~selecting correct should display the form inline in the row in the P&R table~ **handled by #5076**
2) when person or corporation is added to the P&R table, the default action button should be "edit" and the dropdown option should be "Remove". Button is "Edit" not "Correct" in this case.
3) Drop-down alignment - the "Remove" button in the segmented button should be right aligned with the drop-down arrow. *(Also add to IA)*
4) Change Alert Text - Change "Add role" alert to "Missing Role"; ensure colours match the Invision comp. *(Also add to IA)*
**Edit UI handled by #5076**
5) ~Ensure only one completing party is displayed in the People and Roles table (whether added via the Add Person button or the Add a Completing Party button). Test when a pre-existing Completing Party is removed, a new Completing Party is added via the "Add Completing Party" button, and the original Completing Party is restored via an "Undo".~ **fixed by #5076**

- ~When you have an added a NEW person, the primary action should be "edit" and the dropdown action should be "remove".~ same as # 2 above

6) In the case when you are about to correct a person, the primary action should be "correct" and the dropdown action should be "remove".
7) When the person has been corrected, it should show a segmented button with primary action: "undo", dropdown would include "correct" and "remove"

Contributor guide

No contributing guide indexed for this repository

Research direction

Review the People and Roles table and the linked Visual/UX Design ticket (ZenHub issue 5124), separating items already handled by #5076 from the remaining work. Done means items 2–4, 6, and 7 match the specified primary and dropdown actions, alignment, alert wording, and colours.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
design, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.