bcgov / bcgov/entity

AUTH bug - with redirect to BRD

Open
#34,856 0 comments 0 reactions 0 assignees View on GitHub
Entities Team Pay Pay Ops
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

I will say the business search app does not have an affiliation mechanism, but staff can impersonate an account through auth web and it seems that can propagate to BRD and simulate the regular affiliation process as a staff member. I think this is probably what happened and it would be easy to do accidentally. I believe this is an auth team issue.

I replicated the error in DEV:
Sign in as staff
Go to staff dashboard
Under Account Management, view an accounts details (i.e. https://dev.account.bcregistry.gov.bc.ca/account/4093/settings/account-info)
Go back to staff dashboard
Click on 'My Staff Business Registry'
You will see in the url that the account id propagated is the one you previously viewed NOT the staff id (i.e. 4093). This means you are acting as if you are account 4093 with staff privileges
Search for a business, add to table (this is the regular affiliation flow). It will affiliated to the account the staff is acting as

Problematic because auth web is silently adding the previously viewed account id when redirecting to BRD (auth web bug)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the flow in DEV from the staff dashboard: view an account, return to the dashboard, and open My Staff Business Registry. Inspect the auth web redirect and the BRD entry point to determine why the previously viewed account ID is propagated; done means the redirect uses the staff identity and affiliation cannot occur under that account.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
authentication, authorization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.