bcgov / bcgov/entity

UI - Business UI: Include resolution dates in API payload during share structure changes

Open
#34,751 12 comments 0 reactions 1 assignee Claimed by @eve-git View on GitHub
Colin Egress
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Resolution dates are not required for share structure changes per certain filings. There is a validation mismatch currently between the UI and API.

The UI only loads the dates if it matches a filing where it's required but the API is expecting them regardless. Long term fix is to update API validation but this can't be done yet since it will break other current functionality.

Short term/current fix is to include the resolution dates in the share structure payload anytime shareClasses have been changed regardless of file type.

Currently required in: Corrections and Transition - Dev to review/confirm anywhere else (may affect estimate)

Related: #30846

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.