UI - Business Layer/business-dashboard-ui - Remove unnecessary business warnings filtering
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
Warning filtering was implemented to exclude dissolution alerts when a business is in liquidation.
After review, it was determined this was an API bug. Fixed [here](https://app.zenhub.com/workspaces/colin-egress-team-6904d552be2bb0000fa13ad6/issues/gh/bcgov/entity/33703)
Code cleanup required in the [business layer](https://github.com/bcgov/business-ui/blob/main/packages/layers/base/app/stores/business.ts#L74)
And also [business-dashboard-ui](https://github.com/bcgov/business-dashboard-ui/blob/main/src/pages/dashboard.vue#L263)
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the warning-filtering code at packages/layers/base/app/stores/business.ts:74 in business-ui and src/pages/dashboard.vue:263 in business-dashboard-ui. Trace how warnings reach the dashboard, then remove the obsolete filtering in both locations. Done means the cleanup is applied consistently and dissolution alerts are no longer excluded by the UI after the API fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100