bcgov / bcgov/entity

Business Account - refine AccountService

Open
#33,560 0 comments 0 reactions 0 assignees View on GitHub
Entities Team
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Should serve as a good example for future services that wrap other API integrations.
- add __init__ method
- decouple from flask app context (no current_app, etc. - could give option for passing in flask app?)
- sets passed in config (urls, secrets)
- sets logger
- consider setting a passed in 'flags'
- add centralized method for calling the api its wrapping
- Example: https://github.com/bcgov/registries-search/blob/main/search-api/src/search_api/services/authz.py#L49
- add in caching (NOT flask caching as we want the option to use this class without a flask app)
- fill out test suite / rework tests setup

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.