bcgov / bcgov/entity

Filings UI: Digital Business Card tasks for entities UI upgrades

Open
#33,383 1 comment 0 reactions 0 assignees View on GitHub
Entities Team techdebt
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

When Entities UI's (create/filings/edit UI) are upgraded from Vue to Nuxt, work is needed to ensure that Digital Business Card continues to work. Information is required on the tasks that are needed.

The DBC functionality on the UI is contained in [business-filings-ui](https://github.com/bcgov/business-filings-ui/). If the Filings UI is to get migrated out of the current Vue 2 architecture then the DBC code that lives in there would need to be taken into account.

One decision point would be based on finding out which of the following strategies is going forward for moving Filings from Vue2 to Nuxt (assume that's the case)

1. Is "Filings UI" moving forward as a frontend project/component? If so, is DBC functionality be shifted along with that project.
2. or, should DBC be shifted into it's own standalone component separate from Filings. Or is this a necessity anyways if the Filings UI ceases to exist as a grouped project, but Filings are moved elsewhere. **[LO: Having a standalone Nuxt DBC web project/component/whatever seems to me the best/cleanest thing if possible from an encapsulation and separation-of-concerns aspect. It has nothing to do with Filings]** If separating out, this could _probaby_ (haven't verified) be done prior to shifting filings UI over as a standalone task, reducing the scope of a Filings UI shift.

Most of the relevant code is under `src/components/DigitalCredentials/` in Filings UI.

Note there is an LD flag for the ui that gates the entire DBC as an on/off in the frontend: `enable-digital-credentials`
There is `getAllowedActions.digitalBusinessCard` from the backend (which bases decision on business logic and additional LD flags) as well.

---

Note for other UIs that have any DBC reference should they need adjusting (unlikely in scope with this ticket):
- **business-dashboard-ui**: `LinkActions.vue` exposes the "Digital Business Card" link that links out to `/filings/{businessId}/digital-credentials/`. Same LD flag + allowed action check as filings UI.
- **business-ui** base layer: just defines LDFlag.EnableDigitalCredentials. No usage.

Contributor guide

No contributing guide indexed for this repository

Research direction

Review business-filings-ui, especially src/components/DigitalCredentials/, and trace the enable-digital-credentials flag and getAllowedActions.digitalBusinessCard checks. Also inspect business-dashboard-ui's LinkActions.vue for related references. Document whether DBC should move with Filings UI or become a standalone Nuxt component, and list the migration tasks and flag/action behavior that must remain supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nuxt
Domain
frontend, web-dev
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.