Update Business Pay to trigger email only for future effective
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
- Can be addressed when all templates are ready
QA Note: Ensure to test both public filings with payment and staff filings without payment. Verify for all filing types / entity types.
Note: This must go after the templates or be put in first but feature flagged.
Extra notes:
- this is where we publish the email: https://github.com/bcgov/lear/blob/main/queue_services/business-pay/src/business_pay/resources/pay_filer.py#L164
- this just needs some condition logic added
- filing record is available here so can check for future effective etc.
- flags looks to be setup already too if doing a ff
Contributor guide
No contributing guide indexed for this repository
Research direction
Start at queue_services/business-pay/src/business_pay/resources/pay_filer.py around line 164, where the email is published, and inspect the available filing record and existing feature-flag setup. Confirm the behavior for future-effective and non-future filings across public filings with payment and staff filings without payment, covering all filing and entity types. Done means the email triggers only for the intended future-effective cases and the QA matrix passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, payments
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100