bcgov / bcgov/entity

Edit UI: Change of Registration failing for account with no mailing address

Open
#32,184 3 comments 0 reactions 1 assignee Assigned to @mstanton1 View on GitHub
bug Entities Team UX Assurance
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

As an imported account that lacks a mailing address, I want the Change of Registration filing to handle that missing address for the Completing Party, so I don't get errors and can complete the filing.

--

In https://github.com/bcgov/entity/issues/32161, filings were changed to handle imported accounts that don't have a mailing address.

To replicate:
1. Log into dev with a user/account that has had the mailing address removed (eg, BCREG0020, account 2288)
2. Open an active firm
3. Click View and Change Business Information
4. Fill in details and click File Now
5. Observe error

During the filing note that Completing Party is empty:

Image

The filing will fail:

image.png

Due to a 400 response from business-api validation checking the mailing address:

image.png

--

**QA Notes:**
- Will need to set up an account that lacks a mailing address (as done with previous tickets on this subject)
- Change of Registration should work successfully for those users
- Regression test of Change of Registration for other accounts that **do** have a mailing address

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.