bcgov / bcgov/entity

Remove `custodialOffice` from voluntary dissolution

Open
#31,659 0 comments 0 reactions 0 assignees View on GitHub
Entities Team
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Currently API collects `custodialOffice` and party `custodian` in voluntary dissolution (in UI we ask user to provide only `custodian` party with address as one record), which ideally should have the same office. But with this [bug](https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/30932) we found that the UI provides `custodialOffice` as registered office which is wrong. Since its a redundant data and can cause confusion (especially for API users) and we don't use `custodialOffice` in anywhere in the code.

Background: When dissolution was implemented initially we probably referred COLIN which has different approach. COLIN collect `custodialOffice` and custodian name as separate data and created custodialOffice as an office data (DS) and custodian party (RCC) without address

- [x] Remove validation of `custodialOffice` in voluntary dissolution of CORPS from [legal-api](https://github.com/bcgov/lear/blob/main/legal-api/src/legal_api/services/filings/validations/dissolution.py#L408)
- [x] Remove processing of `custodialOffice` from [business-filer](https://github.com/bcgov/lear/blob/main/queue_services/business-filer/src/business_filer/filing_processors/dissolution.py#L84)
- [x] Update [colin-api](https://github.com/bcgov/lear/blob/main/colin-api/src/colin_api/models/filing.py#L1010) to use the custodian party address to update `custodialOffice` (implementation ticket https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/30932)

Cleanup:
- [x] Update API spec and remove from sandbox postman collection
- [ ] Remove `custodialOffice` from dissolution [schema](https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/dissolution.json#L54)
- [ ] Remove setting `custodialOffice` in UI
- [ ] create-ui
- [ ] filing-ui
- [ ] business-dashboard-ui

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.