bcgov / bcgov/entity

BRD UI: new account doesn't see affiliation invitations

Open
#30,826 1 comment 0 reactions 0 assignees View on GitHub
bug Entities Team Priority3
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

**Describe the bug in current situation**
An account with no entities won't see any affiliation invitations it has requested.

**Link bug to the User Story**
N/A

**Impact of this bug**
- Law Firms users
- Individual account owners requiring access back from Law Firms
- A new account can send invitations but not see them. The most likely account to experience this is a new lawyer user (since I expect them to start with an empty BRD and then ask other accounts for authorization to manage the business).

**Chance of Occurring (high/medium/low/very low)**
Low -- new account only, and how many of those will be requesting delegation?

**Pre Conditions: which Env, any pre-requesites or assumptions to execute steps?**
Account must have no entities (affiliations).

**Steps to Reproduce**
1. Login to Dev as a regular user
2. Select an account with no entities (or create a new account)
3. Go to the BRD
4. Request delegation for a business in another account
5. Observe that the request is not displayed in the BRD

**Actual/ observed behavior/ results**

image.png

**Expected behavior**
Even if the account has no entities (affiliations), any invitation requests should be displayed.

**Screenshots/ Visual Reference/ Source**
See above.

**Analysis**
Due to a code bug, when the account has no entities, the call to fetch the affiliation invitations is not made.

affiliations.ts
image.png

Further analysis should be done to determine if there's a reason why this call is inside the "if length > 0" condition.

**Workaround**
Create a dummy draft entity/affilation, eg:
1. go to Namerequest UI
2. select action to create a new BC-based business
3. select type of business = BEN
4. select type = Numbered Company
5. click Incorporate Now
6. go back to your BRD
7. once you have actual business(es) in your BRD, you can delete the draft BEN IA

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in affiliations.ts and reproduce the BRD flow with an account that has no entities. Inspect why the affiliation-invitation fetch is inside the length condition, then verify that requested invitations are displayed for an account without affiliations.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.