bcgov / bcgov/entity

Business Dashboard UI: don't display page until all network calls are done (Phase 1)

Open
#29,318 2 comments 0 reactions 0 assignees View on GitHub
bug Entities Team Priority2
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

See also [Phase 2 ticket](https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/29664).

In Dev, I opened a business to manage it. The business dashboard loaded, initially with no office addresses and no directors. Fifteen seconds later, the addresses and directors displayed.

This happened because the addresses and parties calls took 15 seconds to return, and the data was displayed then. However, my expectation is that the dashboard as a whole doesn't display until this data is fetched, so that an incomplete dashboard is never displayed.

image (1).png

**The required change is to prevent the page from displaying until the addresses and parties calls complete. (Also, please check if there are other calls that should be awaited.)**

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.