bcgov / bcgov/entity

BOR / Reg Search - Update utcnow to func.now() in the model

Open
#26,924 0 comments 1 reaction 0 assignees View on GitHub
BOR Search devops Registry Search
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

The func.now() function will set the default datetimes to the start of the session (this will be the start of the request), which is what we want.
One known issue is that for the tests the session is set at the beginning of the test setup so we will need to look into changing how those tests work (i.e. the default time in the tests will not accurately reflect actual functionality when this is updated)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the BOR / Reg Search model fields that currently use utcnow and the tests covering their default datetimes. Review how the test session is initialized, then update the model defaults and adjust the tests so they verify the session-start time behavior described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sqlalchemy
Domain
backend, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.