bcgov / bcgov/entity

Error handling on NR data changes before client finishes the process

Open
#2,545 2 comments 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

* if the validation fails on the NR when it is checked on this page, big generic error message is shown.
* be able to control data to trigger the validation

**AC**
* WHEN the program first starts or resume a draft filing
* you need to validate it

**Notes**
* validation rules: see: ticket: 2467
* error dialogue (similar to what used before)
* contact Severin for more info in case

**Testing Notes**
* be able to simulate conditions that cause error dialogue (e.g. change data from consle)

**Design**
* @forgeuxGH5 to define different error states in a different ticket to be completed AFTER MVP

Validate NR data
Add validators for:
Supported NR statuses only
Non-expired NRs
Supported request types only
Supported Conditions/Consent statuses only
If validation fails, show error messages:

SCOPE OF THIS TICKET: Generic error message for all failed states
Sienna and Linda to define each error state o be implemented later
@forgeuxGH5 to create a design ticket to capture each error scenario, and will be implemented later
Validate when:
user is on step 1
user enters step 5 (with review page)
user clicks file & pay
If anything about the NR changes mid-draft, and the validation still passes, let them continue.
If anything about the NR changes mid-draft, but the validation does NOT pass, show generic error and kick them out again FOR MVP
Scott, Linda, Sienna to define better behavior for future ticket
Requirements
See story for requirements doc

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.