bcgov / bcgov/entity

Business Dashboard: should not load all comments until they're needed

Open
#25,169 0 comments 0 reactions 0 assignees View on GitHub
Entities Team Priority3 techdebt UX Assurance
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

#### Description

The Business Dashboard loads all filing comments when it initializes, even though the comments are not needed until a filing (ledger item) is expanded/opened. This slows the app's initialization and causes a lot of network traffic (and calls that the API has to respond to) unnecessarily.

#### Steps to reproduce

1. login with BCREG0020
2. open DevTools
3. go to https://dev.business-dashboard.bcregistry.gov.bc.ca/BC0885606?accountid=668
4. observe in Network tab that the detail comments for all filings are being fetched -- they should only be fetched when the filing is expanded (same as documents)

image.png

#### Impact

Slower UI initialization and a ton of network traffic and extra API load that is not needed. The comments should be fetched when a filing (ledger item) is expanded/opened.

The additional delay, for the sample business noted above, is only 1-2 seconds (for about 20 comments). (If a business had more ledger items with comments, it would be more delay.)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.