bcgov / bcgov/entity

Legal API: alteration should allow legal name even if number doesn't match incorp number

Open
#24,421 1 comment 0 reactions 0 assignees View on GitHub
bug Entities Team Priority3
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

A business type alteration was attempted on a business. It failed to file with the following message (which comes from Legal API):

image.png

Re: https://dev.edit.business.bcregistry.gov.bc.ca/BC0871549/alteration/?alteration-id=152399&accountid=668

### Analysis

This business is the result of an amalgamation in which it adopted the name (number, actually) of one of the amalgamating businesses. Hence, its name (in this case, "0871498 B.C. LTD.") does not match its incorporation number (BC0871549).

During the business type change in Edit UI, the previous extension is replaced with a new extension, so the new name is "0871498 B.C. COMMUNITY CONTRIBUTION COMPANY LTD.".

However, Legal API validates this name against the incorporation number and expects "0871549 B.C. COMMUNITY CONTRIBUTION COMPANY LTD.", and reports an error because it doesn't match.

Per @Mihai-QuickSilverDev , the name specified by Edit UI is correct (ie, they keep the old number and only the extension changes). So, Legal API has to allow this. I recommend that Legal API validates only the extension.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.