bcgov / bcgov/entity

Filings UI: don't fetch documents or comments in certain cases

Open
#23,825 3 comments 0 reactions 0 assignees View on GitHub
bug Dependency enhancement Entities Team Priority2
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

In some cases, the `documents` call should not be made because we aren't displaying them.

In some cases, the `comments` call should not be made because the Legal API will return a 404 (Not Found). Example:

image.png

The following needs to be verified, but I think the rules are:
- if this is a bootstrap filing then only fetch documents when it's "filed and pending"
- if this is a bootstrap filing then never fetch comments

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.