bcgov / bcgov/entity

Remove button behaviour

Open
#23,669 0 comments 0 reactions 0 assignees View on GitHub
BTR bug enhancement
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

**Describe the bug in current situation**
Currently the remove button in the edit state is always active and it should only show when the user is adding a new SI or editing an SI that has not been submitted yet. Active SIs that have already been submitted should not be seeing the remove button.

**Expected behaviour:**

Users adding new SI or editing SI that has not be entered in registry yet image.png

Users editing SI already in registry image.png

If user selects remove then we need to have a pop up dialogue to confirm removal before removing: https://www.figma.com/design/4oi1IWHe0DmbY8EZk3Srs3/Add%2Fedit-SI?node-id=2757-21568&t=AYPKneIigyodJpVQ-1

**Impact of this bug**
Users are currently being allowed to remove an SI when editing an SI who is already filed in the registry. The only way a user can remove an SI is on initial entry or edit before SIs have been submitted to the registry. Otherwise the only option to remove is to cease and then delete if the SI is already filed.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the frontend add/edit SI screen described in the issue and compare the two provided screenshots with the linked Figma design. Verify the remove button is limited to new or unsubmitted SIs, and that selecting it shows a confirmation dialog before removal; check both submitted and unsubmitted states.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.