bcgov / bcgov/entity

BE - Create separate module for legal api models

Open
#23,124 0 comments 0 reactions 0 assignees View on GitHub
Entities - Data Migration
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Moving forward, we plan to keep the [legal api models](https://github.com/bcgov/lear/tree/main/legal-api/src/legal_api/models) in a common business model module. We will move over to using the module fully when all the BE components have been upgraded to use the new models module.

BE components are still referencing the legal api models.

Here's [reference code](https://github.com/bcgov/lear/tree/feature-legal-name/python/common/business-registry-model) that we can use. As you can see, there's a new `business-registry-model` that has the legal api models. We need to do something similar here.

**TODOs**

- [ ] Create the module as an installable module (can use reference work)
- [ ] Grab all the models from Legal API and pull them in (can use reference work)
**Note: will probably need some tweaks as our models and sql-versioning will be different from legal name branch (legal name branch is extremely outdated)**
- [ ] Grab all the alembic migrations and we need to make sure they're working
- [ ] ~Grab the unit tests and pull them in and we need to make sure they're working~ _this will be done in https://github.com/bcgov/entity/issues/23164_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.