Business Dashboard / Company Info Page - View only business info
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
After meeting with severin we determined it would make sense to update the edit UI for a view only version of the page. Competent Authority's will only be opening 'alterations', but several other change filings share the same components so we will need to verify them / make sure our logic is not too specific to just 'alteration'.
Discussed using the 'allowable actions' which will depend on how we do https://github.com/bcgov/entity/issues/22030, to inform the below logic
Entity UI logic that needs to be updated for the change buttons shown in the 'alteration':
- **business name**: https://github.com/bcgov/business-edit-ui/blob/main/src/components/common/YourCompany/EntityName.vue#L150
- **business type**: https://github.com/bcgov/business-edit-ui/blob/main/src/components/common/YourCompany/ChangeBusinessType.vue#L380
- **name translation**: https://github.com/bcgov/business-edit-ui/blob/main/src/components/common/YourCompany/NameTranslations/NameTranslation.vue#L289
- **recognition date**: no changes
- **office addresses**: no changes *(all change functionality is for other filing types)*
- **business contact info**: https://github.com/bcgov/business-edit-ui/blob/main/src/components/common/YourCompany/BusinessContactInfo.vue#L7 *has disableActions prop*
- **folio number**: https://github.com/bcgov/business-edit-ui/blob/main/src/components/common/YourCompany/FolioInformation.vue#L8 *has hideActions prop*
- **current directors**: no changes
- **share structure**: https://github.com/bcgov/business-edit-ui/blob/main/src/views/Alteration.vue#L33 *has isEditMode prop*
- **articles**: https://github.com/bcgov/business-edit-ui/blob/main/src/components/Alteration/Articles/CompanyProvisions.vue#L36
Business Dashboard UI:
- alter logic for 'view and change business information' button in the business-dash to follow the same logic
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the listed components in business-edit-ui, especially EntityName.vue, ChangeBusinessType.vue, NameTranslation.vue, BusinessContactInfo.vue, FolioInformation.vue, Alteration.vue, and CompanyProvisions.vue. Read issue #22030 to understand the allowable-actions logic, then inspect the Business Dashboard button logic. Done means the view-only page shows or hides change actions correctly for alterations and other filing types without changing sections marked as requiring no changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100