bcgov / bcgov/entity

Legal API - update business summary output to work with alternate names(FIRST PASS) - part 2

Open
#20,883 0 comments 0 reactions 0 assignees View on GitHub
Entities - Data Migration ENTITY - DO NOT USE
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

This ticket was created to handle the outstanding work done in #20359.

There are still issues with SP DBA person and possibly other firms I think. When I tested FM0554225(SP DBA person), there was an issue in [set_description](https://github.com/bcgov/lear/blob/2492703e8d3a57baa13a2b112ee6f15303c7b063/legal-api/src/legal_api/reports/business_document.py#L184-L200) and various issues in [set_dates](https://github.com/bcgov/lear/blob/2492703e8d3a57baa13a2b112ee6f15303c7b063/legal-api/src/legal_api/reports/business_document.py#L213-L215).

There are likely other issues. There needs to be testing done specifically to test out all the firm specific scenarios.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.