bcgov / bcgov/entity

Legal API - update correction outputs to work with alternate names (FIRST PASS)

Open
#20,368 0 comments 0 reactions 0 assignees View on GitHub
blocked Entities - Data Migration ENTITY - DO NOT USE
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

This is not intended to be an exhaustive update for outputs at this point as we do not have the data migration scripts nailed down yet. But in the meantime, we can update the output code such that we are following the new model and can fix any obvious output generation issues.

To test the filing outputs, it would probably be easiest to pull up the corresponding filings being tested in OCP dev for a given business identifier and compare the output of the listed documents.

**Note: this will be for all business types**

For each output, do the following:
- [ ] Verify able to retrieve documents associated with filing via GET https://business-api-dev-dy4loprnwa-nn.a.run.app/api/v2/businesses//filings//documents endpoint. If endpoint errors out, fix as req’d
- [ ] Determine outputs relevant to business types of interest. Pulling up a firm in OCP may be a quick way to determine expected outputs for a given filing
- [ ] if firm output, update to use alternate names for business name
- [ ] Verify each output loads for relevant business types and fix any basic issues. If a firm, test with a firm imported from COLIN(business identifier starts with FM0) and one created in LEAR(business identifier starts with FM1)
- [ ] More detailed versioning related verification will be done in future tickets when data migration scripts are finalized

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by retrieving the filing documents through the listed business API GET endpoint and compare the outputs with corresponding filings in OCP dev. Check relevant outputs for all business types, including FM0 and FM1 firms, and confirm that firm outputs use alternate names and load without basic errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, javascript, postgres, python
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.