Legal API - update amalgamation outputs to work with alternate names (FIRST PASS)
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
This is not intended to be an exhaustive update for outputs at this point as we do not have the data migration scripts nailed down yet. But in the meantime, we can update the output code such that we are following the new model and can fix any obvious output generation issues.
To test the filing outputs, it would probably be easiest to pull up the corresponding filings being tested in OCP dev for a given business identifier and compare the output of the listed documents.
For each output, do the following:
- [ ] Verify able to retrieve documents associated with filing via GET https://business-api-dev-dy4loprnwa-nn.a.run.app/api/v2/businesses//filings//documents endpoint. If endpoint errors out, fix as req’d
- [ ] Determine outputs relevant to business types of interest. Pulling up a firm in OCP may be a quick way to determine expected outputs for a given filing
- [ ] Verify each output loads for relevant business types and fix any basic issues.
- [ ] More detailed versioning related verification will be done in future tickets when data migration scripts are finalized
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by retrieving the filing documents through the listed GET business API endpoint and compare the corresponding filing outputs in OCP dev for a business identifier. Review the output generation paths for relevant business types, then verify that each output loads and that document retrieval no longer errors. Detailed versioning checks are deferred until migration scripts are finalized.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100