Add offices to the Annual Report JSON Schema
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
In [Pull Request 521](https://github.com/bcgov/lear/pull/521), the business addresses structure changed from
```
data: {
deliveryAddress: { ... },
mailingAddress: { ... }
}
```
to
```
data: {
registeredOffice: {
deliveryAddress: { ... },
mailingAddress: { ... }
},
recordsOffice: {
deliveryAddress: { ... },
mailingAddress: { ... }
}
}
```
In the subject PR, the necessary schema changes were made to the Change Of Address JSON schema, but they were not made to the Annual Report JSON schema; indeed, for AR validation to pass, the 'mailingAddress' and 'deliveryAddress' fields were changed to "not required". Hence, the AR JSON schema is broken (it fails to require/validate addresses).
**This** ticket, then, is to finish the Annual Report JSON schema changes, including:
1. add schema for 'registeredOffice' and 'recordsOffice'
2. make 'registeredOffice' required for Coops and BCorps
3. make 'recordsOffice' required for BCorps only
(These are basically the same changes made to the Change Of Address JSON schema.)
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.