bcgov / bcgov/entity

Shared Components - import Vue3 improved Business Lookup component from Cameron

Open
#19,220 1 comment 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Cameron implemented some nice UX changes to this component, but his version isn't in the bcrs-shared-components repo.

This ticket is to bring in Cam's component (with UX improvements), and make it work like the existing Business Lookup component (which performs the lookup).

Notes: Assets has 2 components related to this feature, both would require porting.
- A component to display and select the search results
- A combo component that provides a mean of capturing search criteria, takes configurations for the text-field and overlay and some useful functionalities.

Task items:
- [ ] Port BusinessSearchAutoComplete (naming is arbitrary, can be called whatever)
- repo link: https://github.com/bcgov/ppr/blob/main/ppr-ui/src/components/search/BusinessSearchAutocomplete.vue
- Additional note: currently contains a hookup to a search composable which houses the request. This will need to refactored to abstract that functionality.

- [ ] Port OrgNameLookup (once again, naming is whatever, please rename to whatever is most appropriate)
- repo link: https://github.com/bcgov/ppr/blob/main/ppr-ui/src/components/common/OrgNameLookup.vue
- Additional note: This component relies on the BusinessSearchAutoComplete.

Example implementation in Assets:

Screenshot 2024-01-10 at 2.46.38 PM.png

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.