bcgov / bcgov/entity

Legal API: DBC allowed check is not using active proprietor record for check

Open
#18,953 4 comments 0 reactions 0 assignees View on GitHub
bug Business Card DBC Phase 3 ENTITY - DO NOT USE Priority2 prod defect
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

When testing the DBC functionality in Prod for go-live, it was determined that there is a scenario where a proprietor could use the DBC functionality even when the proprietor first or last name has been updated to no longer match the registration completing party or BCSC first or last name.

This happens because the current DBC check uses the first proprietor record found which would be the record created when the business was first created. The check should be checking against the active proprietor record.

This issue was found in Prod with FM1003299 using Mihai's BCSC user.

image.png

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the DBC check and trace how it selects a proprietor record, then inspect the proprietor data for the FM1003299 scenario described in the issue. Verify the check uses the active proprietor record rather than the first record found, and add or run coverage for mismatched updated names against the registration completing party or BCSC name.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, postgres, python
Domain
api, backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.