Legal API: Refactor code used to retrieve filing type fee codes
Open
ENTITY - DO NOT USE
techdebt
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
The code in [get_filing_types](https://github.com/bcgov/lear/blob/2f619e9d2cd073b746bbcea53a93310bcdf50efc/legal-api/src/legal_api/resources/v2/business/business_filings/business_filings.py#L637-L636) is a bit of a mess and is prone to introducing bugs.
Refactor it such that it is more generic and across filing types.
As an example, take a look at how future effective dates are currently handled.
TODOs
- [ ] Analysis of how we can refactor code to be more generic
- [ ] Refactor code
- [ ] Add/update unit tests as req'd
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.