Switch the Pay Filer to use Filing Id instead of looking up Payment Token
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
### Switch the Pay Filer to use Filing Id instead of looking up Payment Token
## Description:
Sumesh is going to add Filing Id to the queue message that Pay API adds to the queue when payment is complete. Therefore our Pay Filer can find the filing directly, instead of looking up filing by payment token, which sometimes is too hasty (there's a loop to handle this).
Once we implement this, we can remove the loop code since that was to handle this exact problem.
**Dependencies**
Pay API needs to return Filing Id (work has to be done first).
**Acceptance Criteria**
**Validation Rules**
Ready to Build (DoR):
- [ ] Stakeholders have approved
- [ ] User story completed
- [ ] What are the dependencies
- [ ] Validation rules defined (UI, Data, Role-Action)
- [ ] Is a formal UAT required
Acceptance / DoD:
- [ ] Design / Solution accepted by Product Owner
- [ ] Acceptance criteria has been defined (happy path, known sad paths)
- [ ] Test coverage acceptable
- [ ] Peer Reviewed
- [ ] Accessibility reviewed and acceptable [checklist](https://github.com/bcgov/entity/docs/coding-standards/accessibility.md)
- [ ] UX Approved
- [ ] PR Accepted
- [ ] Production burn in completed
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing the Pay API queue message and the Pay Filer's current payment-token lookup and retry loop. The Pay API dependency must add Filing Id first; done means the filer uses that identifier directly and the obsolete loop is removed, with acceptable test coverage confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100