bcgov / bcgov/entity

Edit UI - Change PDF Upload to reconcile with Create UI

Open
#17,446 0 comments 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE techdebt
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

As it currently stands, PDF upload in Edit UI works in a different fashion from Create UI.

Create UI uses a mixin (`document-mixin.ts`) while Edit UI does everything in one file (`FileUploadPdf.vue`). This ticket is make the implementation similar between both and maybe if possible, make it a shared component.

To Do:
- [ ] Change file upload implementation in Edit UI to be consistent with Create UI
- [ ] Fix required unit tests (if applicable)

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the Edit UI implementation in FileUploadPdf.vue with the Create UI's document-mixin.ts. Start by tracing how each UI handles PDF upload and review the related unit tests. Done means Edit UI behavior is consistent with Create UI, any shared component is appropriate, and affected tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.