Filings UI: refactor Entity Info button call path
- Dominant language
- JavaScript
- Stars
- 23
- Forks
- 62
- Avg merge
- 24m
- Merged PRs (30d)
- 1
Description
This ticket is created in response to a code review comment in https://github.com/bcgov/business-filings-ui/pull/468.
> When the Download Business Summary button is clicked, it:
> - calls a method, `emitDownloadBusinessSummary()`
> - which emits an event called, `downloadBusinessSummary`
> - which is received by the parent, "EntityInfo"
> - which calls another method called, `emitDownloadBusinessSummary`
> - which emits another method called `downloadBusinessSummary`
> - which is received by the parent, "App.vue"
> - which calls another method called, `downloadBusinessSummary`
> - which calls the API and downloads the requested document
>
> Would it be possible to call a store action instead
**To do:**
- [ ] clean up call path for Download Business Summary button
- [ ] clean up call path for Dissolve this Business button
- [ ] consider a common/general path for all action buttons in the Entity Info header
- [ ] consider an architecture so the Entity Info header can be reused in multiple UIs, or used across a merged Filings/Create/Edit UI
Contributor guide
No contributing guide indexed for this repository
Research direction
Trace the Download Business Summary and Dissolve this Business call paths between the Entity Info header, EntityInfo, and App.vue. Review the proposed store-action boundary and the existing button behavior first; done means both paths are cleaned up and the common or reusable Entity Info header architecture is addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100