bcgov / bcgov/entity

Legal API - BEN IA Shares Series Error

Open
#15,720 3 comments 0 reactions 0 assignees View on GitHub
bug ENTITY - DO NOT USE good first issue Priority3
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

When clicking File and Pay this error comes up, however, the Shares step shows no error.

Desired behaviour/To Do List:

- [ ] A Class of shares and a Series inside that class are okay to share the same name.

- [ ] Update Unit Tests

This is based on this answer from the Business' Policy Analyst:
"Can a share series contain the same name as the share class?
Yes. There is nothing in the BCA or BCR that prohibits this naming convention. Additionally I went into test COLIN and tested out these naming conventions; while there cannot be multiple share series with the same name in the same class, nor multiple share classes with the same name, a share class and shares series under that class appears to be able to list the same name."

Existing behaviour:

- [ ] When invoking the "Review and Confirm" page, show that the Shares block has an error.

![image.png](https://images.zenhubusercontent.com/62741a399202cf3570f9fd40/01a0843b-120a-4b47-98dc-6372f5bb67be)

![image.png](https://images.zenhubusercontent.com/62741a399202cf3570f9fd40/2128f479-83b2-496d-9ae1-b6ed47581e53)

![image.png](https://images.zenhubusercontent.com/62741a399202cf3570f9fd40/b59e2bd2-e4f8-4d62-be94-8d76be9ce536)

**Steps to Reproduce**
Steps to reproduce the behaviour:
1. Start a named BEN Incorporation Application
2. Enter a Shares class named Common
3. Add special restrictions to that class, so that you can add a series too
4. Add a series named Common
5. Observe that the Shares module validation does not complain
6. Observe that when clicking File and Pay the error comes up

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Shares module validation and the Review and Confirm/File and Pay flow described in the reproduction steps. Trace why a class and its series may pass module validation but fail at filing, then update the unit tests. Done means matching class and series names are accepted consistently and the relevant validation state is shown in the Shares block.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
full-stack
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.