bcgov / bcgov/entity

LEAR - Operating Name vs Legal Name for SP/GPs

Open
#15,527 2 comments 0 reactions 0 assignees View on GitHub
Entities - Data Migration ENTITY - DO NOT USE Epic
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Lear is returning the operating name for SP/GPs in the field named legal name.

e.g. from Production - FM1005432
Proprietor: Taylor Thurston
Operating name: DR TAYLOR THURSTON ND

GET https://bcregistry-prod.apigee.net/business/api/v2/businesses/FM1005432
returns "legalName": "DR TAYLOR THURSTON ND",

ISSUE:
- The legal API returns the firm's name (operating name) in a field titled Legal Name. This is incorrect.
- An SP's legal name is the name of it's proprietor
- Similarly, the legal name of a GP is the name of it's partners combined and separated by commas.

Impacts:
- BCeID Ops are reporting that some BCeIDs have been set up under the wrong name.
- Vysakh has confirmed that proprietor name and partner names are being correctly mapped for Hub messages from the new system - when the base system is corrected, this will need to be changed.

Proposed Changes:
- Update the Business Schema
- Update the Business Model
- Either plan as rolling changes or Big Bang
- **Rolling**
- Update Filer to save Operating Name
- Modify database to put in the Operating Name
- Modify the history in the database
- Update API to use Operating Name
- Update Outputs
- Update BN
- Update the API for Legal & Operating name
- Update outputs
- Update BN
- Update the Business Search SOLR loader
- **Big Bang**
- Update API
- Update Outputs
- Update BN
- DML to update operating name, legal name, history
- Update the Business Search SOLR loader
- Take a **weekend** outage to update the database and roll in the changes

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Business Schema and Business Model, then inspect the legal API response for FM1005432 and trace how legal and operating names are stored and exposed. Review the proposed API, output, BN, history, and Business Search SOLR loader changes. Done means SP legal names use the proprietor, GP legal names use combined partner names, and operating names remain separate across the affected outputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, postgres, python
Domain
api, backend, database, search
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.