bcgov / bcgov/entity

BCRS shared components: cannot accept Correct Name after toggling options

Open
#15,469 1 comment 0 reactions 0 assignees View on GitHub
bug ENTITY - DO NOT USE Priority2
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

This is an inherent design error in the "correct-name" component (which was ported from Edit UI and is used in Create UI), and fixing it is out of scope for #14783.

**To reproduce:**
1. start a restoration filing
2. expand "Use the incorporation number as the name" form and click the checkbox
3. expand "Use a name request number" form and enter NR data
4. re-expand "Use the incorporation number as the name" form
- observe that checkbox is still checked
- click Done -- observe that nothing happens
5. re-expand "Use a name request number" form
- observe that NR data is still populated
- click Done -- observe that nothing happens

The error is that the forms should be cleared between expansions above... Or, valid forms should be submittable. However, this requires each form to know when it is expanded or collapsed, and the current design doesn't handle this.

**Workaround:**
- on the "Use the incorporation number as the name" form, uncheck then re-check the checkbox, then you can submit it
- on the "Use a name request number" form, re-enter any field, then you can submit it

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.