bcgov / bcgov/entity

Edit UI - Incorrect Name Change Component Validation

Open
#15,149 9 comments 0 reactions 0 assignees View on GitHub
bug ENTITY - DO NOT USE Priority2
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

The Name Change component does not have correct validation checks.

Steps to reproduce:
1. Have an existing SP/GP or register a new one. (also benefit companies)
2. Create and approve a name request for changing the name of the SP/GP.
3. Open the SP's dashboard and click on View and Change Business Information.
4. Click on the Change button beside the business name.
5. Enter the numeric portion of the NR number and press Done.
6. **Observe that the validation error is triggered. We want to allow users enter just the numeric portion of the NR number.**
7. Enter the NR number including the "NR" prefix and press Done.
8. **Observe that nothing happens. Since both phone number nor the email address are not yet entered, both fields should be highlighted red as required field.**

There is an additional problem with named benefit company change name. When you select change, there are two options (use incorp # or use NR #). If you select Done without expanding either, nothing happens. This should act the same as Cancel at this point.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.