bcgov / bcgov/entity

Create UI + Filings UI: change the way Business ID is passed

Open
#14,838 1 comment 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE Priority2 techdebt
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

The current method of passing Business ID from Filings UI to Create UI (eg, for IA, reg or dissolution) does not work for current and future development.

Currently the Business ID is passed in an `id` URL parameter.

Sample URL for an IA (where Business ID is "TcbIHSU9xM"):
`https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/incorporation-define-company?id=TcbIHSU9xM&accountid=3040`

Sample URL for a dissolution (where Business ID is "BC0871191"):
`https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/dissolution-define-dissolution?id=BC0871191&accountid=3040`

The problem is that the current code assumes that a Business ID that starts with CP, BC or FM must be a dissolution (otherwise it's an IA or a reg). This obviously can't work for other filings such as Restoration, where the Business ID will start with BC.

The proposed solution is to change the Create UI URL to contain the Business ID as part of the route, same as Filings UI or Edit UI.

Sample new URL:
`https://business-create-dev.apps.silver.devops.gov.bc.ca/businesses/create/BC0871191/dissolution-define-dissolution?accountid=3040`

- [ ] update URL route processing in Create UI
- including how business ID is parsed - [here](https://github.com/bcgov/business-create-ui/blob/70d1fa97f9ef5970bbed35f632433d66f4909318/src/App.vue#L516)
- including how filing type is parsed - [here](https://github.com/bcgov/business-create-ui/blob/70d1fa97f9ef5970bbed35f632433d66f4909318/src/App.vue#L525) and [here](https://github.com/bcgov/business-create-ui/blob/70d1fa97f9ef5970bbed35f632433d66f4909318/src/App.vue#L789)
- including filing type validation and re-routing - [here](https://github.com/bcgov/business-create-ui/blob/70d1fa97f9ef5970bbed35f632433d66f4909318/src/App.vue#L682)
- see Filings UI or Edit UI for sample code
- [ ] update redirections to Create UI in Filings UI - [here](https://github.com/bcgov/business-filings-ui/blob/8a54472539a624d09d3c7a8bbd886666a4c10ae5/src/App.vue#L774), [here](https://github.com/bcgov/business-filings-ui/blob/8a54472539a624d09d3c7a8bbd886666a4c10ae5/src/components/Dashboard/TodoList.vue#L1366), [here](https://github.com/bcgov/business-filings-ui/blob/8a54472539a624d09d3c7a8bbd886666a4c10ae5/src/components/Dashboard/TodoList.vue#L1373) and [here](https://github.com/bcgov/business-filings-ui/blob/8a54472539a624d09d3c7a8bbd886666a4c10ae5/src/components/Dashboard/TodoList.vue#L1387)
- [ ] if it makes sense (according to code investigation), pass draft filing as `filing-id` (and clean up Legal Services methods accordingly)

The changes above depend on each other and must therefore be deployed at the same time.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.