bcgov / bcgov/entity

No check to ensure province/postal code combos are valid

Open
#14,747 0 comments 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE Priority3
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

There's no validation to check if a province matches its postal code. Not sure if this is a problem, but it seems like it would be easy to validate.

Not sure what "user story" is in this case. I noticed it when I was entering dummy data while unit testing.

Impact is a reduced number of invalid addresses. Chance of Occurring is probably very low.

Steps to reproduce the behavior:
1. Enter an address with a postal code for a conflicting province. e.g. An address in BC has to have a postal code beginning with V, so try entering E4P 2A9 instead.

End result: Invalid province/postal code combos can be submitted.

Expected behavior: A validation error should occur.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.