bcgov / bcgov/entity

LEAR / Edit UI: conversion correction doesn't match schema

Open
#14,214 2 comments 0 reactions 0 assignees View on GitHub
bug ENTITY - DO NOT USE Priority3
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

This was originally reported in #14159, where it was decided to formally allow corrections to (local) conversion filings. However, the underlying schema error was not resolved:

![491120e4-05db-47c2-af5f-2cc1b3549933.png](https://images.zenhubusercontent.com/5d0a7edda4644173e93bf808/0ac8e4df-9c52-4d8f-9f68-280111566ea0)

To begin with, the correction schema doesn't allow "conversion" as a valid Corrected Filing Type ([link to correction schema](https://github.com/bcgov/business-schemas/blob/main/src/registry_schemas/schemas/correction.json)).

Also, "alteration" and "transition" should be added as a valid corrected filing types.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with business-schemas/src/registry_schemas/schemas/correction.json, linked in the issue, and inspect the allowed Corrected Filing Type values. Done means the schema accepts conversion, alteration, and transition so the LEAR edit UI's conversion correction matches it.

Written by the indexing model from the issue text.

Assessment

Tech stack
json
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.