bcgov / bcgov/entity

Legal API: should return empty data object when filing is pending

Open
#13,755 0 comments 0 reactions 0 assignees View on GitHub
bug ENTITY - DO NOT USE
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

To Do:

- [ ] Confirm if this breaks any patterns, before proceeding.
- [ ] Might be a tedious task to test all the scenarios. Riyaz to consult with the Devs as needed.

A Registrar's Notation filing was filed. However, the filer wasn't picking things up from the queue. As a result, the filing was missing a `data` object:

![Clipboard - September 27, 2022 3_00 PM.png](https://images.zenhubusercontent.com/5d0a7edda4644173e93bf808/a30f75e6-0a8c-422b-a817-691e209c5356)

The missing data object caused the Filings History List to throw an error for this filing and not display it. Instead, it should have displayed this filing as "pending".

To fix this, the Legal API should return an empty `data` object when the filing is pending.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the Legal API response for a pending Registrar's Notation filing and how the Filings History List handles it. Check existing coverage for pending filings, if present; done means the API returns an empty data object and the filing is displayed as pending without an error.

Written by the indexing model from the issue text.

Assessment

Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.