bcgov / bcgov/entity

SBC Common Comp: BaseAddress field(s) should not validate while typing

Open
#11,320 3 comments 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE Priority3
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Currently, the `deliveryInstructions` text field in the BaseAddress component validates that the value doesn't have any leading, trailing, or consecutive space characters. (This was implemented to prevent issues in later processing.) This causes bad UX while a user types in something with spaces between words.

Proposed solution: Only perform validation after user leaves the subject input (ie, blur event).

@tlebedovich All address fields validate these "space rules". Should only the delivery address perform deferred validation, or all fields? Should this be a toggle that only some instances of the base address component use?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the BaseAddress component and the deliveryInstructions field mentioned in the issue. Trace where the space-rule validation runs and how the blur event is handled. Before changing behavior, resolve whether deferred validation applies only to deliveryInstructions, all address fields, or selected BaseAddress instances; done means typing spaces no longer causes premature validation while leaving the field still validates.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.