bcgov / bcgov/entity

Legal API - IA should not use business object in filing

Open
#11,133 3 comments 0 reactions 0 assignees View on GitHub
bug ENTITY - DO NOT USE Priority2
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

**Describe the bug in current situation**
IA validation is depending on `business/legalType` property. Even though it is working now it is against schema. To get legalType we can use `namerequest/legalType`. Make sure business object not used in case of IA

**Expected behaviour**
Business object is not used in case of IA

**TO DO**
- [ ] Investigate what needs to be done and document it in this ticket
- [ ] Update validator to **not** validate the legal type using the business object
- [ ] Ignore the business object even if it is there

.

- UI work (to be completed in ____)
- Backend work to (be completed in ____ )

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the IA filing validator and trace how it reads legalType from business/legalType versus namerequest/legalType. Document the required change in this issue, then ensure the validator ignores business even when present and add or update the relevant validation coverage; no file or test is named in the payload.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.