bcgov / bcgov/entity

Document service must validate the request before generating the output

Open
#10,283 0 comments 0 reactions 0 assignees View on GitHub
ENTITY - DO NOT USE
Dominant language
JavaScript
Stars
23
Forks
62
Avg merge
24m
Merged PRs (30d)
1

Description

Currently when the request for a specific type of document is received, the API does not validate whether that document type is present in the allowed list of documents for that filing. As a result, there is a very high chance of issuing incorrect documents if the API is accessed directly (not via UI). We need to add a validator to the document service to prevent this.

Cc: @thorwolpert @lmcclung

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the document service request handler and the allowed list of documents for each filing. Trace how a requested document type reaches output generation, then verify that unsupported types are rejected when the API is called directly while allowed types still generate successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
flask, python
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.