bcgov / bcgov/ccissr

exclude low-productivity BGCs from summary results

Open
#32 2 comments 0 reactions 1 assignee Claimed by @kdaust View on GitHub
Release: v1.0 Type: Bug
Dominant language
R
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

The ccissr summary workflow doesn't seem to exclude non-THLB BGCs as was done for the CCISS paper. this is an important step because it means it prevents overstating the expansion potential of a species by including alpine/parkland/grassland.

there is a table in ccissr/data_raw called BGCs_notin_THLB.csv that specifies BGCs to exclude. however it is not up to date for the BGC list.

tasks:

- [x] align BGCs_notin_THLB.csv with current BGC list
- [x] update new units for correct status (with input from Will/Colin)
- [x] make it a data object, or add it as a column in an existing data object
- [ ] set up a workflow so this table can't go out of date (e.g., an automated test for alignment between data tables)
- [ ] update all plots and summaries so that they exclude the specified BGC units (likely best as a function parameter with default TRUE).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.