bcgov / bcgov/bcgwcat

Missing data when params doesn't list an AquaChem unit

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Unit conversion when there is no AquaChem unit results in the `RESULT2` being NA and effectively removes that sample.
Not ideal!

To fix
1. Get the unit it should be in AquaChem
2. If there is no unit, no conversion and use the EMS unit

Contributor guide

Open the contributing guide

Research direction

Start by finding the unit-conversion path that produces RESULT2 and inspect how AquaChem and EMS units are selected. Verify the behavior with a sample whose parameter has no AquaChem unit: conversion should be skipped and the EMS unit retained instead of RESULT2 becoming NA.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, r
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.