bcgov / bcgov/bcgovr

Tidy up various tryCatch statements when upstream fixes get implemented

Open
#39 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
R
Stars
36
Forks
5
PR merge metrics
No merged PRs in 30d

Description

We currently have workarounds for a couple of issues/bugs in usethis:

- [ ] `create_from_bcgov_github()` [has this](https://github.com/bcgov/bcgovr/blob/devel/R/create.R#L185-L205) and `use_bcgov_github()` [has this](https://github.com/bcgov/bcgovr/blob/devel/R/use.R#L205-L217), both of which should be able to be removed when [this hits CRAN](https://github.com/r-lib/usethis/pull/340)
- [x] `use_bcgov_template()` [has this](https://github.com/bcgov/bcgovr/blob/use_bcgov_template/R/use.R#L261-L272), which should be removed if [this gets accepted](https://github.com/r-lib/usethis/pull/350).

Contributor guide

Open the contributing guide

Research direction

Start with the tryCatch workarounds in R/create.R and R/use.R, specifically create_from_bcgov_github(), use_bcgov_github(), and use_bcgov_template(). Check whether the linked usethis pull requests have reached CRAN or been accepted. Done means removing only the workarounds whose upstream fixes are available and confirming the affected functions still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.