bcgov / bcgov/bcfms

checkbox-boolean-widget has multiple false values

Open
#210 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
2
PR merge metrics
No merged PRs in 30d

Description

**To Reproduce**
Steps to reproduce the behavior:
1. Create a new Contributor with type type as "Individual" and the "Paleo Consultant" role and do not check the "Invalid" checkbox
2. Go to an existing IPA -> Requirement Submission Process -> Submission card
3. Activate the "Lead Paleo Consultant" dropdown
4. Note the newly created contributor is in the list
5. Edit he contributor created in 1
6. Check the Inactive checkbox & press Save
7. Uncheck the Inactive checkbox & press Save
8. Return to the IPA used in 2 and activate the "Lead Paleo Consultant" dropdown
9. Note the Consultant is no longer in the list

**Actual Behavior**
Newly created records have boolean value of null

**Expected Behavior**
Newly created records should have boolean value of false

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
The fix is in the bcgov-arches-common repo, which fixes the JS and has a migration to fix the card_x_node_x_widget data (defaultValue is null, not false). Additional migration needs to be run in bcfms to fix the existing data in BCFMS.
related issue is here: bcgov/bcgov-arches-common#154

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the bcgov-arches-common JavaScript for checkbox-boolean-widget and its migration for card_x_node_x_widget, comparing defaultValue handling for null and false. Then inspect the BCFMS migration needed for existing data and verify the reproduction flow no longer removes the contributor from the dropdown.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
database, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.