bcgov / bcgov/bcdata_py

bc2pg - improve type mapping

Open
#204 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
32
Forks
7
Avg merge
21h 3m
Merged PRs (30d)
15

Description

As per #178, `bc2pg` creates `numeric` postgres columns for BCDC `NUMBER` columns.

Should `bcdata` :

- automatically inspect the data to determine if it is integer and adjust the type accordingly?
- accept an optional field map argument for overriding the BCDC types, maybe something like `{"field_name1": "numeric", "field_name2": "integer"}`?
- parse the `data_precision` part of the schema?

As data are read by geopandas when writing to postgres:

- if providing a mapping, easiest would be to use sqlalchemy types: https://geopandas.org/en/stable/docs/reference/api/geopandas.GeoDataFrame.to_postgis.html
- if running the type optimization automatically, pandas has a method: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.convert_dtypes.html

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.