Stop 'Under Review by ALC' email from sending if a decision has ever been released on the application
- Dominant language
- TypeScript
- Stars
- 10
- Forks
- 0
- Avg merge
- 20h 8m
- Merged PRs (30d)
- 30
Description
Niche workflow reveals that the Under Review by ALC email is sending when we don't want it to:
Submit application to ALC > Release decision > Add a Review Date (via Review tab) in the past > Revert decision to draft
--> Under Review by ALC email sends
**Acceptance Criteria**
- [ ] If an application was submitted to the ALC before Feb 12, 2024, never send the Under Review by ALC email if any decision has been released (alcs.application_decision.was_released = TRUE)
Confirm this task meets our team [**Definition of Ready (DoR)**](https://www.figma.com/board/XmNkN600aAVWFCBmSDdt10/Team-Documents?node-id=1-2&t=Xjd6nHZZ7YlnoOrD-4) before moving to the **Next Sprint** column.
Confirm this task meets our team [**Definition of Done (DoD)**](https://www.figma.com/board/XmNkN600aAVWFCBmSDdt10/Team-Documents?node-id=3-21&t=Xjd6nHZZ7YlnoOrD-4) before moving to the **Done** column.
Contributor guide
No contributing guide indexed for this repository
Research direction
Search the codebase for the "Under Review by ALC" email and for alcs.application_decision.was_released to find the notification entry point and its tests. Reproduce the workflow described in the issue, then verify that an application submitted before February 12, 2024 does not receive the email after any decision has been released, including when the decision is later reverted to draft.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100